Tool Selection

This section is dedicated to the feature & improvement requests (be sure what you are asking does not exist yet in TVPaint Animation ;) )
Post Reply
User avatar
mox
Posts: 1023
Joined: 13 Feb 2006, 19:24
Contact:

Tool Selection

Post by mox »

suggestion for Tool: Select:
It would be nice to have a "display" option to check, this way we could do the actions for the display, instead of the current layer only.
Selection_display.png
Selection_display.png (7.38 KiB) Viewed 1713 times
Jerome Lorin
Moxica (playground)
(Win11/TVP 11.7.3-64 bits pro)
User avatar
Peter Wassink
Posts: 4431
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Tool Selection

Post by Peter Wassink »

i'm thinking why?
the selection is in fact always over the entire project and not layer based.
so if you apply an effect or a tool on multiple layers it will then make use of the selection in 'display' mode anyway, just as you request here, no?

i wanted to test if my assumption was correct.
by applying a blur on all layers while a selection is active...

but it did not work as expected! one of the lines in this example simply vanished !?
weird bug
in the preview only the active layer gets a preview of the effect
if you are on the purple layer and apply the purple line disappears
and if you are on the green layer when you apply the green layer disappears...
however if you `then click anywhere the layer pops back up with both layers showing and with the applied FX on both layers in the selection area only.
note FXstack is set to 'apply on all layers'
bug.jpg
bug.jpg (79.86 KiB) Viewed 1660 times
.
the active layer disappears after applying...
bug not 1.jpg
bug not 1.jpg (21.05 KiB) Viewed 1658 times
.
but clicking anywhere brings it back with the added FX
bug not.jpg
bug not.jpg (21.29 KiB) Viewed 1658 times
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
kelanhordos
Posts: 92
Joined: 06 Aug 2019, 01:09
Contact:

Re: Tool Selection

Post by kelanhordos »

I wonder if Max is maybe thinking along the lines of this being useful as an option for affecting layers like the drop down menu in the transform tools? Right now there is Current Layer/Current Group/All Layers/Selected layers, but perhaps a DISPLAY would be useful as a quick way to select the layers that are enabled rather than having to select them all/add them to color groups etc. I could see this being really useful in theory, although all the apply on multiple layer tools are a bit cumbersome to use at times due to lack of being able to see a preview of multiple layers. Hoping we get the ability to see all the layers affected in the preview in the life of v12!

Peter are you using v12.0.2? I've had some "refresh" issues where the display doesn't seem to update over the couple days until I scroll over it when I've done a few things like transformations/pasting etc. I can't remember if this was happening before the new patch, maybe related but could be a coincidence.

One interesting thing that v12 added is under the ERASE tool there is now a drop down "Apply ON" box as well. It is a bit laggy, but gives you the ability to erase on multiple layers at once.
PC: Windows 10/64 Pro - TUF Gaming H470-PRO, i9-10900F@ 2.8 GHz - 32Gb RAM
Tvpaint 12.0.1 Pro
Wacom Cintiq 16 Driver: 6.4.7-3
User avatar
mox
Posts: 1023
Joined: 13 Feb 2006, 19:24
Contact:

Re: Tool Selection

Post by mox »

Yes, each FX can be applied on all layers at once within a selection indeed.

But outside the FX Stack? In the case you make a selection and want to copy/cut to brush the whole display, you can't. You have to crop to a new project then you will be able to make the brush.

About the "Erase tool" I don't remember it was a thing until now!
So what does prevent this option to be available everywhere?
Last edited by mox on 09 Oct 2024, 14:19, edited 1 time in total.
Jerome Lorin
Moxica (playground)
(Win11/TVP 11.7.3-64 bits pro)
kelanhordos
Posts: 92
Joined: 06 Aug 2019, 01:09
Contact:

Re: Tool Selection

Post by kelanhordos »

Hi Max, maybe I am misunderstanding, but regarding cut/copythe brush, isn't that what the "Display" option already does if you have it toggled?
cutbrushdisplay.jpg
cutbrushdisplay.jpg (39.44 KiB) Viewed 1433 times
Also just for clarity in regards to what I said above, I was thinking outside the FX stack when you use the transform/perspective tool, in this menu.
transformmenu.jpg
transformmenu.jpg (63.44 KiB) Viewed 1433 times
PC: Windows 10/64 Pro - TUF Gaming H470-PRO, i9-10900F@ 2.8 GHz - 32Gb RAM
Tvpaint 12.0.1 Pro
Wacom Cintiq 16 Driver: 6.4.7-3
User avatar
mox
Posts: 1023
Joined: 13 Feb 2006, 19:24
Contact:

Re: Tool Selection

Post by mox »

kelanhordos wrote: 09 Oct 2024, 13:48 Hi Max, maybe I am misunderstanding, but regarding cut/copythe brush, isn't that what the "Display" option already does if you have it toggled?
Yes, that is my point, to have the same option for the selection :D
When the stencil is on, you know/see what you are grabbing, it is accurate while cutting a brush is on the fly.
Jerome Lorin
Moxica (playground)
(Win11/TVP 11.7.3-64 bits pro)
kelanhordos
Posts: 92
Joined: 06 Aug 2019, 01:09
Contact:

Re: Tool Selection

Post by kelanhordos »

Oh, I think I understand now. There actually is a way to do what I think you are looking for, you just have to use display on/off under the cut brush tool before using select. You probably already know this and are just looking for the option for these settings in the select menu, but just in case.

All of the options under cutbrush tools; copy/cut, display, keep etc. will affect the Shortcut > Shape Select > Copy to CustomBrush, which you can use with a selection from the select tool.

For example

Go to cut brush, and make sure DISPLAY IS ON
Use the freehand select tool > make a selection
Use the shortcut(you will have to assign a key to it) > Shape Select > Copy to CustomBrush
This will act just like the cut/copy brush but with the select tool, and viola you have your brush cut with the DISPLAY and your selection, rather than just the single layer, and you can use the select tool to precisely grab what you want.

Now that I realize what you are asking, I remember also finding it annoying to have to go into the cutbrush menu to toggle those settings to affect my selection, as sometimes you want the display, sometimes just the layer. I would actually think if it wouldnt break anything the whole menu of cut options could be under select for using that shortcut so you don't have to go back to the cut tool. It's actually the predominant way I cut/copy things, because as you mentioned if you mess up when using the cut tool, its "on the fly" and you have to reselect, which obviously is also useful in it's less buttons, but sometimes I need several selections on the canvas to cut/copy as well.

I made a script for myself to toggle the DISPLAY option so I don't need to go into that menu, and it also stays on your current tool. I'm not sure if it's the best way to do it or if there is any bugs(it works well enough for me until now), or another script on the forum somewhere that is better, but you can try it if you like. You can add this code to a embedded script in an action and it should work(the //print stuff is for debugging but also a reminder of whats happening).

Maybe another alternative would be these options in the cut menu should be able to have shortcuts that can be set by default. And while mentioning it, the other toggleable options like drying/warp/projection should all have shortcuts by default in my opinion.

Code: Select all

tv_getactiveshape
curshape = result

IF CMP(curshape, cutrect) == 0

	//print "not cutrect"
	curtool = null
	tv_getactivetool
	parse result curtool _

	tv_cmd tv_setactiveshape cutrect display
	parse result _ displaystate

	tv_getactiveshape
	tool = result
	//print tool displaystate

	IF displaystate == 0
		//print display ON
		tv_cmd tv_setactiveshape tool display 1
	ELSE
		IF displaystate == 1
			//print display OFF
			tv_cmd tv_setactiveshape tool display 0 
		END
	END
		//print Other tool active
		tv_getactivetool curtool
	

ELSE
	
	//print Cutrect

	tv_cmd tv_setactiveshape cutrect display
	parse result _ displaystate

	tv_getactiveshape
	tool = result
	//print tool displaystate

	IF displaystate == 0
		//print display ON
		tv_cmd tv_setactiveshape tool display 1
	ELSE
		IF displaystate == 1
			//print display OFF
			tv_cmd tv_setactiveshape tool display 0 
		END
		

		exit
		test = CMP(curtool, cutrect) 
	
		If test == 0
			//print Other tool active
			tv_getactivetool curtool
		END
	END
END
PC: Windows 10/64 Pro - TUF Gaming H470-PRO, i9-10900F@ 2.8 GHz - 32Gb RAM
Tvpaint 12.0.1 Pro
Wacom Cintiq 16 Driver: 6.4.7-3
User avatar
mox
Posts: 1023
Joined: 13 Feb 2006, 19:24
Contact:

Re: Tool Selection

Post by mox »

Thanks to your detailed explanation, I found out why where was maybe a bit of a misunderstanding.

If I follow the steps you wrote not using a shortcut (for copy to custombrush for instance), it won't grab the display, layer only.
Using a shortcut it does work! It makes no sense :shock:

That means it is possible to do it, it is working in the engine but the option is not "linked" to the menu/buttons?

I never used a shortcut for this very option, so I don't know if it's an old feature or a bug :mrgreen:
Jerome Lorin
Moxica (playground)
(Win11/TVP 11.7.3-64 bits pro)
kelanhordos
Posts: 92
Joined: 06 Aug 2019, 01:09
Contact:

Re: Tool Selection

Post by kelanhordos »

Haha, Oh that's very interesting and now I see more where you are coming from! I don't remember if I actually ever used that menu for copy/cut, at least not in a long time so I didn't realize it didn't work the same way. Probably a bug?
PC: Windows 10/64 Pro - TUF Gaming H470-PRO, i9-10900F@ 2.8 GHz - 32Gb RAM
Tvpaint 12.0.1 Pro
Wacom Cintiq 16 Driver: 6.4.7-3
Post Reply