Have the specifications of KeyFramer FX changed?

Please use this part to report bugs & errors, ask questions & "How to..."
User avatar
Hironori Takagi
Posts: 313
Joined: 14 May 2018, 10:15
Location: Tokyo, Japan
Contact:

Have the specifications of KeyFramer FX changed?

Post by Hironori Takagi »

I received a message from a user in Japan saying that the specifications of KeyFramer FX have changed since before,
and I checked it out. Indeed, even if you hit the same key in two places, the trajectory is different.
240621_to_tvp.png
In many cases, a straighter trajectory is preferable, but do you know why?
TVPaint 11.7.2(Nov 14 2023), Windows11 Pro, HP Spectre x360 Convertible 14-ea0xxx / TVPaint 11.7.1(Dec 22 2022) Mac OS 11.6, Apple MacBookPro M1 2020
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

Yes!
i noticed this too,
And that was, coincidentally this week, as i tried to answer a forum question on how to do a move in perspective and i could not make it go in a straight line!
in seems as if the Z-axis is broken. it introduces an unexpected and unwanted curve, making this feature unusable.
Last edited by Peter Wassink on 21 Jun 2024, 11:19, edited 1 time in total.
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

Here is that thread
i removed my explanation there because when i tried it out myself it acted as Hironori described
and not as i remember TVPaint doing it before.

Unless there is some logical reason for this behaviour that i missed, i consider it a bug that should be fixed.

viewtopic.php?t=16476

z-camera is set to 1000:
z-axis broken.jpg
z-axis broken.jpg (56.9 KiB) Viewed 3674 times
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
User avatar
s.decol
Site Admin
Posts: 43
Joined: 01 Oct 2019, 10:34

Re: Have the specifications of KeyFramer FX changed?

Post by s.decol »

It's not a bug, but more a side effect due to the fact that now transformations of the keyframer are applied from the pivot point. So if you want to make the movement like in 11.7.0 or lower versions, you have to move your pivot point in order to make it stay always at the same place in the space of the drawing area between two keys (as the coordinates of the pivot point are relative to the coordinates of the center). Maybe we could add an option to let the user choose whether the coordinates of the pivot should be relative to the center or should be "global".
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

s.decol wrote: 21 Jun 2024, 14:00 It's not a bug, but more a side effect due to the fact that now transformations of the keyframer are applied from the pivot point. So if you want to make the movement like in 11.7.0 or lower versions, you have to move your pivot point in order to make it stay always at the same place in the space of the drawing area between two keys (as the coordinates of the pivot point are relative to the coordinates of the center). Maybe we could add an option to let the user choose whether the coordinates of the pivot should be relative to the center or should be "global".
I don't fully understand your explanation.
i could not make it work in a straight line!?
Did i miss something and can you explain how i would achieve a straight motion in the above example?
I hope you can, but i'm afraid the Offset Pivot solution needs to be looked at again.

Because what is clear is the current behaviour is very disorienting, to the point of rendering the z-function useless.
Last edited by Peter Wassink on 21 Jun 2024, 17:40, edited 1 time in total.
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

..
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
kelanhordos
Posts: 94
Joined: 06 Aug 2019, 01:09
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by kelanhordos »

+1 I ran into this problem a while back and couldn't figure out what on earth I was doing wrong. I tried playing with the offset as mentioned above, but I am not sure I understand as if I move the offset it moves the camera bounding box as well. Adding more keys with the offset just makes matters worse as there is more than one curve instead of straight line.
PC: Windows 10/64 Pro - TUF Gaming H470-PRO, i9-10900F@ 2.8 GHz - 32Gb RAM
Tvpaint 12.0.1 Pro
Wacom Cintiq 16 Driver: 6.4.7-3
User avatar
Hironori Takagi
Posts: 313
Joined: 14 May 2018, 10:15
Location: Tokyo, Japan
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Hironori Takagi »

s.decol wrote: 21 Jun 2024, 14:00 It's not a bug, but more a side effect due to the fact that now transformations of the keyframer are applied from the pivot point. So if you want to make the movement like in 11.7.0 or lower versions, you have to move your pivot point in order to make it stay always at the same place in the space of the drawing area between two keys (as the coordinates of the pivot point are relative to the coordinates of the center). Maybe we could add an option to let the user choose whether the coordinates of the pivot should be relative to the center or should be "global".
I understand how to calculate the pivot point and set it to a position that does not move,
but I think it is a bit difficult to explain the same method to someone who is not interested in programming and mathematics.
The behavior of 3D layers in Adobe After Effects was also designed to be naturally linear in the same way. I would like to see improvement.
TVPaint 11.7.2(Nov 14 2023), Windows11 Pro, HP Spectre x360 Convertible 14-ea0xxx / TVPaint 11.7.1(Dec 22 2022) Mac OS 11.6, Apple MacBookPro M1 2020
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

Hironori Takagi wrote: 24 Jun 2024, 01:46
I understand how to calculate the pivot point and set it to a position that does not move,
but I think it is a bit difficult to explain the same method to someone who is not interested in programming and mathematics.
how?
as a veteran tvpaint/keyframer user i have no idea how to do it. and i really tried it.

Keyframer is broken
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
User avatar
s.decol
Site Admin
Posts: 43
Joined: 01 Oct 2019, 10:34

Re: Have the specifications of KeyFramer FX changed?

Post by s.decol »

kelanhordos wrote: 21 Jun 2024, 17:46 +1 I ran into this problem a while back and couldn't figure out what on earth I was doing wrong. I tried playing with the offset as mentioned above, but I am not sure I understand as if I move the offset it moves the camera bounding box as well. Adding more keys with the offset just makes matters worse as there is more than one curve instead of straight line.
If the bounding box of the camera moves when you move your pivot, It's certainly because you move the center WITH the pivot. Make sure the checkbox beside the "Position parameter" is unchecked.
User avatar
s.decol
Site Admin
Posts: 43
Joined: 01 Oct 2019, 10:34

Re: Have the specifications of KeyFramer FX changed?

Post by s.decol »

Peter Wassink wrote: 24 Jun 2024, 06:51
Hironori Takagi wrote: 24 Jun 2024, 01:46
I understand how to calculate the pivot point and set it to a position that does not move,
but I think it is a bit difficult to explain the same method to someone who is not interested in programming and mathematics.
how?
as a veteran tvpaint/keyframer user i have no idea how to do it. and i really tried it.

Keyframer is broken
No keyframer is definitely not broken, you just don't understand its new behaviour. But I'm gonna dig into it to make it easier to use... Once again...
User avatar
Hironori Takagi
Posts: 313
Joined: 14 May 2018, 10:15
Location: Tokyo, Japan
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Hironori Takagi »

Peter Wassink wrote: 24 Jun 2024, 06:51
Hironori Takagi wrote: 24 Jun 2024, 01:46
I understand how to calculate the pivot point and set it to a position that does not move,
but I think it is a bit difficult to explain the same method to someone who is not interested in programming and mathematics.
how?
as a veteran tvpaint/keyframer user i have no idea how to do it. and i really tried it.

Keyframer is broken
240625_to_peter_1.png
240625_to_peter_1.png (74.28 KiB) Viewed 3469 times
240625_to_peter_2.png
I created this diagram to help artists, not programmers, understand a little better. I hope it will be helpful.
TVPaint 11.7.2(Nov 14 2023), Windows11 Pro, HP Spectre x360 Convertible 14-ea0xxx / TVPaint 11.7.1(Dec 22 2022) Mac OS 11.6, Apple MacBookPro M1 2020
User avatar
TVPUSER
Posts: 99
Joined: 30 Jan 2021, 02:29

Re: Have the specifications of KeyFramer FX changed?

Post by TVPUSER »

I've come across this issue myself, I think for the sake of simplicity, having an option for the old pivot position or simply reverting the functionality back would be a good move.
TVPaint 11.7.3, 12.0.1 Pro 64, Windows 10 H
i7-8700k, 48GB, RTX 2080 8G Desktop, Cintiq Pro 24 (3840x2160)
Ryzen 9 5900HS,16GB, RTX 3060 6G Laptop, Wacom ONE 13 Touch (1920x1080)
User avatar
Hironori Takagi
Posts: 313
Joined: 14 May 2018, 10:15
Location: Tokyo, Japan
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Hironori Takagi »

I also agree with the idea of ​​reverting it. I would like it to be applied to TVPaint11.7.x as well.
TVPaint 11.7.2(Nov 14 2023), Windows11 Pro, HP Spectre x360 Convertible 14-ea0xxx / TVPaint 11.7.1(Dec 22 2022) Mac OS 11.6, Apple MacBookPro M1 2020
User avatar
Peter Wassink
Posts: 4436
Joined: 17 Feb 2006, 15:38
Location: Amsterdam
Contact:

Re: Have the specifications of KeyFramer FX changed?

Post by Peter Wassink »

Thank you Hironori!
That helps. (although that second image is not easy to decipher)

I would also like an option for the old pivot
one weird aspect of the new behavior is that when the offset/pivot is not ticked
so no blue circle ... yet when you then change the offset value, the green pivot does noy change, which i find confusing.
Peter Wassink - 2D animator
• PC: Win11/64 Pro - AMD Ryzen 9 5900X 12-Core - 64Gb RAM
• laptop: Win10/64 Pro - i7-4600@2.1 GHz - 16Gb RAM
Post Reply